Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

chore: add sample nuxt app #24

Merged
merged 2 commits into from
Sep 4, 2023
Merged

chore: add sample nuxt app #24

merged 2 commits into from
Sep 4, 2023

Conversation

rdunk
Copy link
Member

@rdunk rdunk commented Sep 4, 2023

Adds a sample Nuxt application alongside the Next.js example.

Uses a wrapper component to demonstrate toggling visual editing which can be applied to any Vue 3 app, rather than using Nuxt specific app hooks.

@rdunk rdunk requested a review from a team as a code owner September 4, 2023 16:30
@vercel
Copy link

vercel bot commented Sep 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlays-nextjs ❌ Failed (Inspect) Sep 4, 2023 4:58pm

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
nuxt 3.7.0 network, environment +19 6.85 MB danielroe

@socket-security
Copy link

socket-security bot commented Sep 4, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@rdunk
Copy link
Member Author

rdunk commented Sep 4, 2023

Relevant issue for reasoning behind using shamefully-hoist at root level related to Nuxt and pnpm not playing nicely together.

nuxt/nuxt#14146

@stipsan
Copy link
Member

stipsan commented Sep 4, 2023

Socket is a bit over-eager here, ignore it.

@SocketSecurity ignore @nuxt/telemetry@2.4.1

Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The hoisting should be fine.
The Vercel build error, and the other errors, seems to be because I forgot to add a turbo.json. I'll fix that after merging :D

@stipsan
Copy link
Member

stipsan commented Sep 4, 2023

@SocketSecurity ignore @nuxt/telemetry@2.4.1

@stipsan stipsan merged commit eecde42 into sanity-io:main Sep 4, 2023
8 of 9 checks passed
@rdunk rdunk deleted the feat/nuxt-app branch September 5, 2023 07:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants