fix: globs not working on windows #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snorrees
approved these changes
Mar 19, 2023
stipsan
changed the title
stipsan
changed the title
stipsan
dismissed
snorrees’s stale review
Got PR approval from @snorrees offline 👍
stipsan
approved these changes
Mar 20, 2023
|
There were a couple of failing windows tests, fixing them in another commit and merging for now. Need to bootup my windows box 🧑💻 |
|
🎉 This PR is included in version 2.2.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
blueputty01
added a commit
to blueputty01/sanity-plugin-icon-picker
that referenced
this pull request
Jun 12, 2023
Watch doesn't work on windows (github.com/sanity-io/pkg-utils/pull/85)
blueputty01
added a commit
to blueputty01/sanity-plugin-icon-picker
that referenced
this pull request
Jun 12, 2023
Watch doesn't work on windows (github.com/sanity-io/pkg-utils/pull/85)
christopherafbjur
pushed a commit
to christopherafbjur/sanity-plugin-icon-picker
that referenced
this pull request
Jun 15, 2023
* Modify line break eslint and prettier configs Line break mismatch on Windows vs. Mac/Linux machines * Add sample configurations from #39 * Add support for storing icon SVGs as strings #37 * Update @sanity/pkg-utils Watch doesn't work on windows (github.com/sanity-io/pkg-utils/pull/85) * Refactor svg string const into function --------- Co-authored-by: Alexander Yang <65861156+blue-putty@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84 and related @sanity/plugin-kit issue.