fix(core): emit reconnect on non-channel error in dataset copy job listener #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). perf-studio – ./🔍 Inspect: https://vercel.com/sanity-io/perf-studio/EP4aE5d2692WHhYkNC9HhNWTTFPH test-studio – ./🔍 Inspect: https://vercel.com/sanity-io/test-studio/4SvWgvTBwTzbDHaojY8EGECepYSk studio-workshop – ./dev/workshop🔍 Inspect: https://vercel.com/sanity-io/studio-workshop/FqqRKoqST8f8uCbc9oK6UA3YrZRE |
rexxars
changed the title
rexxars
force-pushed
the
copy-dataset-reconnect-listener
branch
from
ba77036
to
b65eb51
Compare
rexxars
force-pushed
the
copy-dataset-reconnect-listener
branch
from
b65eb51
to
fb7b404
Compare
rexxars
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an error copying the dataseteven when copying is in progress. This PR adds a reconnection logic non-channel error.channel_errorand notchannelError, which caused CLI to skip the actual error from console.