Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[form-builder] Move item remove logic to ConfirmButton #368

Merged
merged 1 commit into from
Nov 19, 2017
Merged

[form-builder] Move item remove logic to ConfirmButton #368

merged 1 commit into from
Nov 19, 2017

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Nov 19, 2017

Minor cleanup: Moves confirm button popover visibility state out of ItemValue and back into ConfirmButton

@bjoerge
Copy link
Member Author

bjoerge commented Nov 19, 2017

This should be a pretty non-controversial change, so merging.

@bjoerge bjoerge merged commit 10a0245 into next Nov 19, 2017
@bjoerge bjoerge deleted the chore/cleanup-confirm-button branch November 19, 2017 16:33
@rexxars rexxars mentioned this pull request Nov 24, 2017
Merged
rexxars pushed a commit that referenced this pull request Nov 24, 2017
@bjoerge @rexxars
[form-builder] Move item remove logic to ConfirmButton (#368)
684a956
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofferjs kristofferjs Awaiting requested review from kristofferjs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bjoerge