Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add @types/lodash #5753

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix(core): add @types/lodash #5753

merged 1 commit into from
Feb 15, 2024
+4 −0

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 15, 2024

Description

Adds missing @types/lodash to workspace root.

What to review

Does pnpm check:types report any errors?

@juice49 juice49 requested a review from a team as a code owner February 15, 2024 15:16
@juice49 juice49 requested review from ricokahler and removed request for a team February 15, 2024 15:16
@vercel Vercel
Copy link

vercel bot commented Feb 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Feb 15, 2024 3:18pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 3:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 3:18pm

@juice49 juice49 requested review from bjoerge and removed request for ricokahler February 15, 2024 15:17
@juice49 juice49 changed the title fix(core): add `@types/lodash fix(core): add @types/lodash Feb 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

Component Testing Report Updated Feb 15, 2024 3:25 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 19s 9 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 7s 18 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

bjoerge
bjoerge approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏼

@juice49 juice49 added this pull request to the merge queue Feb 15, 2024
Merged via the queue into next with commit 59f8afd Feb 15, 2024
40 checks passed
@juice49 juice49 deleted the fix/lodash-types branch February 15, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juice49 @bjoerge