Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): add notification data for tasks document and tasks comments #5998

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

This PR adds the necessary changes for the notification context that will be received by the server when a task is created or edited and when a comment is added to a task.

Tasks documents

The following context.notification data will be added

 context = {
  notification: {
    targetContentImageUrl:
      'https://cdn.sanity.work/images/exx11uqh/playground/9f76911628de8342e7976997644fb7462e8cdcce-1500x843.jpg?rect=329,0,843,843&w=96&h=96',
    targetContentTitle: 'Test Book',
    workspaceTitle: 'Staging',
    url: 'http://localhost:3333/staging/?sidebar=tasks&selectedTask=1c5cf082-78eb-4b0f-81b2-6f28217463be&viewMode=edit',
  },
}

Comments

When a comment is added into a task, the notification payload will have the same properties as in a field comment and will also include the tasks subscribers ids.

What to review

Testing

Notes for release

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 14, 2024 2:18pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 2:18pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 2:18pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Component Testing Report Updated Mar 14, 2024 2:21 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 58s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 11s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

@hermanwikner hermanwikner self-requested a review March 14, 2024 12:28
@pedrobonamin pedrobonamin added this pull request to the merge queue Mar 14, 2024
Merged via the queue into next with commit 8e63552 Mar 14, 2024
36 checks passed
@pedrobonamin pedrobonamin deleted the tasks-notifications branch March 14, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants