fix(typegen): move type new line separator into formatter #6649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
stipsan
previously approved these changes
May 14, 2024
| @@ -63,7 +63,7 @@ registerBabel() | |||
|
|
|||
| function maybeFormatCode(code: string, prettierConfig: PrettierOptions | null): Promise<string> { | |||
| if (!prettierConfig) { | |||
| return Promise.resolve(code) | |||
| return Promise.resolve(`${code}\n`) // add an extra new newline, poor mans formatting | |||
|
No changes to documentation |
|
Component Testing Report Updated May 14, 2024 11:19 AM (UTC)
|
sgulseth
force-pushed
the
fix/typegen-prettier-new-line
branch
from
b73f5e3
to
2d004b3
Compare
stipsan
approved these changes
May 14, 2024
bjoerge
approved these changes
May 14, 2024
ricokahler
pushed a commit
that referenced
this pull request
May 14, 2024
* fix(typegen): move type new line separator into formatter * fix(typegen): remove double linebreak between schema and query types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prettier were adding a newline, and then we were adding an additional new line to each type. This moves new line into the maybeFormatCode to either rely on prettier adding it, or adding it manually if prettier is not found.
What to review
Testing
We have test that checks a snapshot, these are updated
Notes for release
fixes a bug where typegen would add an additional new line between types.