Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @sanity/presentation and remove deprecated internal exports no longer in use #6694

Merged
merged 4 commits into from
May 17, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented May 16, 2024

Description

Follows up on #6684.
It adds back the original CODEOWNERS on file paths that CDX want to review to ensure backwards compatibility. This allows the Studio DX and EX teams to continue to receive code review requests in the same way as before #6684 merged.

It also bumps @sanity/presentation to a new version that no longer use the deprecated imports:

import {
  type CommentIntentGetter,
  CommentsIntentProvider,
} from 'sanity/structure'

Internally it now uses:

import {
  type CommentIntentGetter,
  CommentsIntentProvider,
} from 'sanity'

And it's tested working on https://visual-editing-studio.sanity.build already 🙌

What to review

If presentation continues to work as it does here https://test-studio.sanity.build/presentation/presentation then we're good to go.

Testing

Existing tests are sufficient

Notes for release

N/A as it's an internals refactor that makes no difference to userland.

@stipsan stipsan requested a review from a team as a code owner May 16, 2024 09:38
@stipsan stipsan requested review from ricokahler and removed request for a team May 16, 2024 09:38
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:38am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:38am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 9:38am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) May 16, 2024 9:38am

@stipsan stipsan enabled auto-merge May 16, 2024 09:38
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated May 16, 2024 9:47 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 30s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 14s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 1m 7s 17 0 1
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 6s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 19s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 26s 12 0 0

Copy link
Contributor

@ricokahler ricokahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@stipsan stipsan added this pull request to the merge queue May 17, 2024
Merged via the queue into next with commit 69246c1 May 17, 2024
39 checks passed
@stipsan stipsan deleted the update-codeowners branch May 17, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants