fix(core/form): prohibit focus and unset on root input #6706
+201
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated May 22, 2024 10:58 AM (UTC)
|
jtpetty
reviewed
May 16, 2024
packages/@sanity/portable-text-editor/src/editor/hooks/useSyncValue.ts
Outdated
Show resolved
Hide resolved
jtpetty
reviewed
May 16, 2024
packages/@sanity/portable-text-editor/src/editor/hooks/useSyncValue.ts
Outdated
Show resolved
Hide resolved
This will disallow the object edit input to set onFocus([]) and unset([]) on itself, as this will disrupt the pattern the PT-input uses for editing it's embedded objects.
…set for embedded PT-forms
pedrobonamin
approved these changes
May 22, 2024
This was referenced Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: this PR builds on top of #6705 and this should be merged first.This will prohibit that a input for a object modal inside the PT-input can call
onPathFocusorunset()on itself.Calling
onPathFocus([])will focus the editor element and close the editing modal.Also if the input calls
unset()on itself (like the Reference Input) it will cause the modal to abruptly dissapear, and we might miss out on any cleanup and other expected functions in the editor when this happens.This change will make sure that any input for the PT-content inside the editor will not be allowed to do this.
onPathFocus([])will be a no-op, andunset([])will instead reset the object (keeping_keyand_type) allowing the editor to deal normally with the object (will be removed when the modal is closed and object it empty).Also added test for this.
What to review
That it seems like a good idea and the proper solution.
Testing
Should be covered by automatic tests. See an example in the provided story if you want to test manually.
Notes for release