Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tasks): reduce tasks sidebar zoffset #6718

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(tasks): reduce tasks sidebar zoffset #6718

merged 1 commit into from
May 21, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Modals have a z-index of 600.
Popover have a z-index of 400.
Tooltips have a z-index of 200

Reducing tasks sidebar to 100, the same as the navbar to stay below modals, popovers and tooltips, it will still sit on top of the elements that were discovered as breaking on the previous fix when this was moved to 1000.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested review from a team and skogsmaskin and removed request for a team May 21, 2024 07:07
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 7:07am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 7:07am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 7:07am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) May 21, 2024 7:07am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated May 21, 2024 7:15 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 32s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 19s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 2s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 30s 12 0 0

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pedrobonamin pedrobonamin added this pull request to the merge queue May 21, 2024
Merged via the queue into next with commit 5ab0819 May 21, 2024
39 checks passed
@pedrobonamin pedrobonamin deleted the edx-1377 branch May 21, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants