Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): unable to open block style select when in nested PTEs in fullscreen #6738

Merged
merged 7 commits into from
May 24, 2024

Conversation

RitaDias
Copy link
Contributor

Description

Fix issue where if you had nested PTEs you would not be able to open the block style dropdown

Before

Screen.Recording.2024-05-22.at.17.27.39.mov

What to review

The code makes sense, the tests make sense.
Should we add some more tests? Thought about component but since the dropdown itself existed in the UI just had the "hidden" property I considered that the e2e was the best approach. Let me know if that is not correct

Testing

Tests are written
You can also manually test on the All Bells and Whistles on the last PTE: content

Notes for release

Fixes issue where nested fullscreen PTEs were unable to open the block style dropdown

@RitaDias RitaDias requested a review from a team May 22, 2024 15:29
@RitaDias RitaDias requested a review from a team as a code owner May 22, 2024 15:29
@RitaDias RitaDias requested review from pedrobonamin and binoy14 and removed request for a team May 22, 2024 15:29
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 7:54am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 7:54am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 7:54am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 7:54am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 7:54am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented May 22, 2024

Component Testing Report Updated May 24, 2024 7:41 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 32s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 38s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 19s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 7s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 22s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 32s 12 0 0

@RitaDias
Copy link
Contributor Author

For context: There seems to be some current issues on the Check if the React Compiler are able to optimize everything / lint that is currently unrelated to this PR

binoy14
binoy14 previously approved these changes May 22, 2024
Copy link
Contributor

@binoy14 binoy14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working as expected, thanks!

test/e2e/tests/pte/Toolbar.spec.ts Show resolved Hide resolved
@RitaDias
Copy link
Contributor Author

Noticed that one of the tests wasn't waiting for the nested full screen, hence the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants