Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle React Compiler errors #6750

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented May 23, 2024

Description

Fixes some issues that were flagged by the compiler that are simple to clear up.

What to review

Everything works the same

Testing

Existing tests should be enough to cover possible regressions. And the perf impact can be tested by trying the test-next-studio Vercel deploy on the PR

Notes for release

N/A

@stipsan stipsan requested a review from a team May 23, 2024 09:51
@stipsan stipsan requested a review from a team as a code owner May 23, 2024 09:51
@stipsan stipsan requested review from skogsmaskin and jtpetty and removed request for a team May 23, 2024 09:51
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 10:03am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 10:03am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 10:03am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 10:03am

@stipsan stipsan enabled auto-merge May 23, 2024 09:51
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated May 23, 2024 10:01 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 38s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 15s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 30s 12 0 0

Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants