Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): update e2e test for toolbar in PTE to be more reliable #6811

Merged
merged 1 commit into from
May 30, 2024

Conversation

RitaDias
Copy link
Contributor

Description

This test was a bit flaky now it should be a bit more sturdy where it checks that the portal has some children (with each opened full screen in PTE more children are added and so are checked).

What to review

That it makes sense, maybe there is a better approach to this?

Notes for release

Improves the sturdiness of e2e tests for Portable Text Editor

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 2:01pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 2:01pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 2:01pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 2:01pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 2:01pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) May 30, 2024 2:01pm

Copy link
Contributor

No changes to documentation

@RitaDias RitaDias requested a review from skogsmaskin May 30, 2024 14:08
Copy link
Contributor

Component Testing Report Updated May 30, 2024 2:09 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 17s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 29s 12 0 0

@RitaDias RitaDias marked this pull request as ready for review May 30, 2024 14:10
@RitaDias RitaDias requested a review from a team as a code owner May 30, 2024 14:10
@RitaDias RitaDias requested review from ricokahler and removed request for a team May 30, 2024 14:10
Copy link
Contributor

@ricokahler ricokahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing god's work

@RitaDias RitaDias added this pull request to the merge queue May 30, 2024
Merged via the queue into next with commit cd901d1 May 30, 2024
44 checks passed
@RitaDias RitaDias deleted the sturdy-full-screen-pte branch May 30, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants