fix(cli): fixes an issue where vendor deps were not found in monorepos #6868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Espen Hovlandsdal <espen@hovlandsdal.com>
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This was referenced Jun 6, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
No changes to documentation |
|
Component Testing Report Updated Jun 10, 2024 4:38 PM (UTC)
|
ricokahler
approved these changes
Jun 7, 2024
bjoerge
approved these changes
Jun 7, 2024
binoy14
force-pushed
the
06-06-fix_cli_fixes_an_issue_where_vendor_deps_were_not_found_in_monorepos
branch
from
807001a
to
c42f659
Compare
|
Merged into parent branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIXES SDX-1390
Fixes an issue where the path for vendor package.json did not resolve correctly in monorepos. It also changes the file path to use the package.json's dirname instead of trying to resolve again from the root.
What to review
Changes makes sense
Testing
TODO, probably need a more high level testing of the build command in the perspective of the flag
Notes for release
N/A