fix(cli): don't set tagged versions as min version #6817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
No changes to documentation |
|
Component Testing Report Updated May 30, 2024 4:59 PM (UTC)
|
Co-authored-by: Espen Hovlandsdal <espen@hovlandsdal.com>
* feat(cli): build user peer-deps * chore: remove shared-modules build * test(cli): verify build config and `exports` subpaths * text(cli): add depcheck config for fixture projects * docs: update comments and test name * feat: create import map w/ installed sanity version (#6784) * feat: create import map w/ installed sanity version * fix: use correct URL
binoy14
commented
May 31, 2024
| import {noopLogger} from '@sanity/telemetry' | ||
| import rimrafCallback from 'rimraf' | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore This may not yet be built. |
There was a problem hiding this comment.
don't believe this is need anymore since it uses paths
binoy14
commented
May 31, 2024
| @@ -8,7 +8,7 @@ export interface AutoUpdatesImportMap { | |||
| '@sanity/vision/': string | |||
| } | |||
|
|
|||
| const MODULES_HOST = 'https://api.sanity.work' | |||
| const MODULES_HOST = 'https://sanity-cdn.work' | |||
There was a problem hiding this comment.
changing the URL, will update it further when ready
binoy14
requested review from
ricokahler,
rexxars and
cngonzalez
and removed request for
a team
ricokahler
approved these changes
May 31, 2024
|
Merged into the parent |
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using a canary or similar tagged version of the studio it adds that tagged version to the min version which is not allowed. This changes it so that it coerces the version and only sets the version part as the min version.
This PR also changes the host to proper one. More changes to follow there
What to review
Changes make sense
Testing
This probably requires a more general integration test suite for this which can be done after things are properly setup
Notes for release
N/A