Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): update timeouts for opening popovers #6871

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Conversation

RitaDias
Copy link
Contributor

@RitaDias RitaDias commented Jun 7, 2024

Description

  • Update two e2e tests that tend to be flaky on next because the timeout runs out

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 0:24am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 0:24am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 0:24am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 0:24am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 0:24am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 0:24am

Copy link
Contributor

github-actions bot commented Jun 7, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Component Testing Report Updated Jun 10, 2024 1:14 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 19s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 29s 12 0 0

Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me.

It's not a blocker, but I wonder whether we should do something to prevent accumulating a bunch of arbitrary timeout durations across the test suite.

@RitaDias
Copy link
Contributor Author

RitaDias commented Jun 11, 2024

Thanks! This looks good to me.

It's not a blocker, but I wonder whether we should do something to prevent accumulating a bunch of arbitrary timeout durations across the test suite.

Yeah I've tried looking for ways (without timeouts) where these tests wouldn't be flaky but I came up short given the time I had.
The good part of it is: the timeouts will only run up to those times if the CI does indeed need all of that time, otherwise they will run "shorter".
I ran these tests multiple times just to be sure that they weren't consistently flaking, however, if any of these tests are still flaky once we merge this then I think I'll need to spend some proper time looking into it and coming up with an approach. Fingers crossed though 🤞

@RitaDias RitaDias added this pull request to the merge queue Jun 11, 2024
Merged via the queue into next with commit 1befff1 Jun 11, 2024
45 checks passed
@RitaDias RitaDias deleted the sturdy-pte-toolbar branch June 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants