Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean playwright-ct cache on each run #6928

Merged
merged 1 commit into from
Jun 13, 2024
Merged

chore: clean playwright-ct cache on each run #6928

merged 1 commit into from
Jun 13, 2024

Conversation

sjelfull
Copy link
Member

Description

When running playwright component tests locally we often have a problem with stale playwright cache, that is separate from the cache in the monorepo.

This change makes sure the cache is deleted every time you run test:ct.

@sjelfull
chore: clean playwright-ct cache on each run
f693044 
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
@sjelfull sjelfull requested a review from a team June 13, 2024 11:52
@sjelfull sjelfull self-assigned this Jun 13, 2024
@sjelfull sjelfull requested review from ninaandal and removed request for a team June 13, 2024 11:52
@sjelfull sjelfull requested a review from a team as a code owner June 13, 2024 11:52
@sjelfull sjelfull requested review from rexxars and removed request for a team June 13, 2024 11:52
@vercel Vercel
Copy link

vercel bot commented Jun 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:56am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:56am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:56am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:56am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 11:56am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Jun 13, 2024 11:56am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Jun 13, 2024 12:02 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 31s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 45s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 35s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 15s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 6s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 29s 12 0 0

@sjelfull sjelfull added this pull request to the merge queue Jun 13, 2024
Merged via the queue into next with commit 18aee90 Jun 13, 2024
43 of 44 checks passed
@sjelfull sjelfull deleted the chore/clean-playwright-cache-on-run branch June 13, 2024 12:21
juice49 pushed a commit that referenced this pull request Jun 13, 2024
@sjelfull @juice49
chore: clean playwright-ct cache on each run (#6928)
286aaed 
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
@justmogen justmogen mentioned this pull request Jul 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skogsmaskin skogsmaskin skogsmaskin approved these changes

@ninaandal ninaandal Awaiting requested review from ninaandal

@rexxars rexxars Awaiting requested review from rexxars rexxars was automatically assigned from sanity-io/sdk

Assignees

@sjelfull sjelfull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjelfull @skogsmaskin