-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): upgrade pnpm setup to use node20 #6968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
No changes to documentation |
Component Testing Report Updated Jun 19, 2024 9:07 PM (UTC)
|
stipsan
reviewed
Jun 18, 2024
stipsan
changed the title
chore(ci): upgrade pnpm setup to yse node20
chore(ci): upgrade pnpm setup to use node20
Jun 18, 2024
stipsan
approved these changes
Jun 19, 2024
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
sjelfull
force-pushed
the
chore/upgrade-pnpm-setup-to-node20
branch
from
June 19, 2024 20:56
ba3c327
to
fcb29b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrades
pnpm/action-setup@v2
that uses Node 16 to v4 that uses Node 20. This gets rid of the deprecation warnings in GH actions. This version is also more strict and requires you to install the exact version if you have definedpackageManager
in package.json.What to review
Any downsides to upgrading? I know we do tests against Node 18 as well, but don't think this affects that in any way?