Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): upgrade pnpm setup to use node20 #6968

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

sjelfull
Copy link
Member

@sjelfull sjelfull commented Jun 18, 2024

Description

This upgrades pnpm/action-setup@v2 that uses Node 16 to v4 that uses Node 20. This gets rid of the deprecation warnings in GH actions. This version is also more strict and requires you to install the exact version if you have defined packageManager in package.json.

What to review

Any downsides to upgrading? I know we do tests against Node 18 as well, but don't think this affects that in any way?

@sjelfull sjelfull requested a review from stipsan June 18, 2024 09:54
@sjelfull sjelfull self-assigned this Jun 18, 2024
@sjelfull sjelfull requested a review from a team as a code owner June 18, 2024 09:54
@sjelfull sjelfull requested review from cngonzalez and removed request for a team June 18, 2024 09:54
Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 8:58pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 8:58pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 8:58pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 8:58pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 8:58pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2024 8:58pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jun 18, 2024

Component Testing Report Updated Jun 19, 2024 9:07 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 37s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 7s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 32s 11 7 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 52s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 14s 20 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 5s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 7s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 21s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 15s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 30s 12 0 0

Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Signed-off-by: Fred Carlsen <fred@sjelfull.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants