fix(migrate): fixes error message to be more helpful #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
No changes to documentation |
binoy14
force-pushed
the
06-18-fix_migrate_fixes_error_message_to_be_more_helpful
branch
from
8bf33d5
to
c127717
Compare
|
Component Testing Report Updated Jun 18, 2024 7:08 PM (UTC)
|
ricokahler
approved these changes
Jun 18, 2024
Comment on lines
+47
to
+58
| const mockResponse = { | ||
| status: 500, | ||
| statusText: 'Internal Server Error', | ||
| json: () => | ||
| Promise.resolve({ | ||
| error: { | ||
| type: 'validationError', | ||
| description: 'Document is not of valid type', | ||
| }, | ||
| status: 500, | ||
| }), | ||
| } |
There was a problem hiding this comment.
If our env supports the response constructor, this may be nicer
Suggested change
| const mockResponse = { | |
| status: 500, | |
| statusText: 'Internal Server Error', | |
| json: () => | |
| Promise.resolve({ | |
| error: { | |
| type: 'validationError', | |
| description: 'Document is not of valid type', | |
| }, | |
| status: 500, | |
| }), | |
| } | |
| const mockResponse = new Response( | |
| JSON.stringify({ | |
| error: { | |
| type: 'validationError', | |
| description: 'Document is not of valid type', | |
| }, | |
| status: 500, | |
| }), | |
| { | |
| status: 500, | |
| statusText: 'Internal Server Error', | |
| }, | |
| ) |
There was a problem hiding this comment.
probably worth doing it but maybe in a follow up PR, would need to change a few tests
binoy14
deleted the
06-18-fix_migrate_fixes_error_message_to_be_more_helpful
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like the error response from backend is in the shape below
When we receive error in this shape we don't properly log that message making it hard for folks to debug. See screenshots below
Before
After
What to review
Copy and change makes sense, I checked the repo and there seems to be other places checking
error.descriptionso I am not sure if error will not be an object but I added a conditional to keep backwards compatibilityTesting
Updated the test
Notes for release