Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structure): fix incorrect i18n key for discard changes button "no changes" status #7008

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

passion4code
Copy link
Contributor

@passion4code passion4code commented Jun 21, 2024

Description

Old: action.discard-changes.disabled.no-changes
New: action.discard-changes.disabled.no-change

This is to match what is in https://github.com/sanity-io/locales/

What to review

Localization key for the alt text on the "Discard Changes" action when it is disabled.

Testing

https://github.com/sanity-io/locales/blob/main/locales/fr-FR/src/structure.ts#L17 for an example of the key translated / used

Notes for release

None

Old: `action.discard-changes.disabled.no-changes`
New: `action.discard-changes.disabled.no-changes`

This is to match what is in https://github.com/sanity-io/locales/
@passion4code passion4code requested a review from a team as a code owner June 21, 2024 21:32
@passion4code passion4code requested review from ricokahler and removed request for a team June 21, 2024 21:32
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 9:35pm
performance-studio ✅ Ready (Inspect) Visit Preview Jun 21, 2024 9:35pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 9:35pm

Copy link

vercel bot commented Jun 21, 2024

@passion4code is attempting to deploy a commit to the Sanity Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rexxars rexxars changed the title Fixes NO_CHANGES localization key fix(structure): fix incorrect i18n key for discard changes button "no changes" status Jun 26, 2024
@rexxars rexxars added this pull request to the merge queue Jun 26, 2024
Merged via the queue into sanity-io:next with commit 428679a Jun 26, 2024
6 of 9 checks passed
ricokahler pushed a commit that referenced this pull request Jun 26, 2024
Old: `action.discard-changes.disabled.no-changes`
New: `action.discard-changes.disabled.no-changes`

This is to match what is in https://github.com/sanity-io/locales/
ricokahler pushed a commit that referenced this pull request Jun 27, 2024
Old: `action.discard-changes.disabled.no-changes`
New: `action.discard-changes.disabled.no-changes`

This is to match what is in https://github.com/sanity-io/locales/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants