Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when deleting GDDragonBones node 3.2 dev #31

Closed
Sky84 opened this issue Nov 20, 2019 · 5 comments
Closed

Error when deleting GDDragonBones node 3.2 dev #31

Sky84 opened this issue Nov 20, 2019 · 5 comments

Comments

@Sky84
Copy link

Sky84 commented Nov 20, 2019

Hello,
An error is showed and the game crash when it's poped. The error is not everytime and i don't know why.
It occur when changing scene or deleting the GDDragonBones node.

DB resource (res://Animations/Mobs/dromadaire/dromadaire_ske.json) loaded in 1 msecs DB resource (res://Animations/Player/player_ske.json) loaded in 0 msecs DB resource (res://Animations/PNJ/pnj_ske.json) loaded in 1 msecs DB resource (res://Animations/Mobs/wildsawaji/wildsawaji_ske.json) loaded in 0 msecs CrashHandlerException: Program crashed Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues [0] String::copy_from (C:\Users\Maison\Documents\godot-master\core\ustring.cpp:160) [1] String::String (C:\Users\Maison\Documents\godot-master\core\ustring.cpp:1623) [2] StringName::operator String (C:\Users\Maison\Documents\godot-master\core\string_name.h:123) [3] Node::remove_child (C:\Users\Maison\Documents\godot-master\scene\main\node.cpp:1244) [4] GDDragonBones::_cleanup (C:\Users\Maison\Documents\godot-master\modules\gddragonbones\gddragonbones.cpp:131) [5] GDDragonBones::~GDDragonBones (C:\Users\Maison\Documents\godot-master\modules\gddragonbones\gddragonbones.cpp:111) [6] GDDragonBones::'scalar deleting destructor' [7] memdelete<Object> (C:\Users\Maison\Documents\godot-master\core\os\memory.h:119) [8] SceneTree::_flush_delete_queue (C:\Users\Maison\Documents\godot-master\scene\main\scene_tree.cpp:1128) [9] SceneTree::iteration (C:\Users\Maison\Documents\godot-master\scene\main\scene_tree.cpp:490) [10] Main::iteration (C:\Users\Maison\Documents\godot-master\main\main.cpp:1953) [11] OS_Windows::run (C:\Users\Maison\Documents\godot-master\platform\windows\os_windows.cpp:3136) [12] widechar_main (C:\Users\Maison\Documents\godot-master\platform\windows\godot_windows.cpp:162) [13] _main (C:\Users\Maison\Documents\godot-master\platform\windows\godot_windows.cpp:184) [14] main (C:\Users\Maison\Documents\godot-master\platform\windows\godot_windows.cpp:196) [15] __scrt_common_main_seh (d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288) [16] BaseThreadInitThunk

@Ranoller
Copy link
Contributor

Ranoller commented Jan 18, 2020

Well, i investigate and only seems to happend when the scene is executed with F6 and not with F5. The error is triggered some times because gddragonbones constructor/destructor method have not a copy method. I´m not c++ programmer so it will cost me, first, study the constructor/destructor methods in c++, then study dragon bones code base, and later try to implement the copy method. If some one has the skills and the time, solutions are discused here:

https://stackoverflow.com/questions/17840579/scalar-deleting-destructor-issue/17840926

If not, i can´t promisse that i can have the time/skills to fix that.

@Ranoller
Copy link
Contributor

Ranoller commented Jan 18, 2020

I opened issues system in my fork because @sanja-sa has no activity in github in the last year, so i suppose he will not attend any bug/issue/pull request.

Ranoller added a commit to Ranoller/gddragonbones that referenced this issue Jan 19, 2020
…tance. Fix sanja-sa#31 closes #1 (I hope). It doesn´t seem to leak memory, I seems godot free the memory with the last deleted dragonbones instance
@Ranoller
Copy link
Contributor

Please @Sky84 try to compile from here to test if bug has gone:
https://github.com/Ranoller/gddragonbones

@Sky84
Copy link
Author

Sky84 commented Jan 22, 2020

Going to try later, i guess tonight

@Sky84
Copy link
Author

Sky84 commented Jan 24, 2020

Ok, seems to be fixed... :)

@Sky84 Sky84 closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants