fix: catch and re-reject failed promise from sftp() #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a hard time with occasional crashs of my app due to rejection in
https://github.com/sanketbajoria/ssh2-promise/blob/master/src/sshConnection.ts#L80
It could happen, if the server closes the connection (for whatever reason) before sftp subsystem is "ready", maybe during completion of handshake. The error from ssh2 is "No response from server", originated in ssh2\lib\client.js:764:19.
Turns out, the rejected promise is not handled in
https://github.com/sanketbajoria/ssh2-promise/blob/master/src/sftp.ts#L29
so the app crashs with "unhandled promise" exception.
My fix catches the rejected async promise and uses the error for rejecting the current promise.
Now, the error can be handled by the application: