Rebase #5
Closed
Rebase #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read #[validate(...)] attributes
Default values that don't implement Serialize are now ignored, rather than causing a compile error. This is done by simulating specialization using a technique copied from Rocket: https://github.com/SergioBenitez/Rocket/blob/5ebefa97c992c37bdc476299304a339d429a43fc/core/lib/src/sentinel.rs#L391-L445 Fixes #115
The comment in the code says this code was copied from another source with an appropriate link. However just local to this file it is not clear what the license terms of that code are. I added the license notice to this file that governs the particular code that was copied over. I would like to use this crate in an environment where we want to be clear about licensing. Hopefully this is an okay change otherwise I would be more than happy to do this a different way as long as the license provenance is clear.
Deriving `Debug` is no longer enough to suppress warnings about unused fields
Signed-off-by: Randy Barlow <randy.barlow@deepgram.com>
Based on #162 Co-authored-by: teozkr <teo@nullable.se>
Co-authored-by: Graham Esau <gesau@hotmail.co.uk>
serde_json 1.0.25 brings in the json! macro that is used here (https://github.com/serde-rs/json/releases/tag/v1.0.25)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.