This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Заменяем объект State на комбинацию DelayReasonState/Status #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamwildtuna
reviewed
Mar 18, 2019
src/Common/DelayReasonState.php
Outdated
| * | ||
| * @var int | ||
| */ | ||
| private $CityCode; |
There was a problem hiding this comment.
А не перепутаны DelayReasonState и Status? Ведь код города и город как раз в статусе заказа, а не причинах задержки.
There was a problem hiding this comment.
Да, это ошибка. Тут этих свойств вообще не должно быть.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В целях обратной совместимости на замену объекту
State, который использовался двусмысленно (код статуса имел разный смысл в разных обстоятельствах), приходят объектыDelayReasonStateиStatus. Они имплементируют тот же интерфейс, так что весь код, использовавший объектState, должен продолжить так же, как обычно, даже не смотря на отсутствующие методы (даже если у нас есть объект какого-то интерфейса, PHP даёт вызывать на нём даже методы, которые не объявлены в интерфейсе).make.makeилиmake ci).