Non-hardcoded versions #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanIvanoff
reviewed
May 31, 2022
| @@ -22,7 +22,7 @@ | |||
| 'Cython' | |||
| ], | |||
| install_requires=[ | |||
| 'pandas==1.3.0', | |||
| 'pandas>=1.3.0', | |||
There was a problem hiding this comment.
How does >= work? Does it mean that only the last digit in the version can change (i.e. from 1.3.0 to 1.3.99, but not to 1.4.0) or all versions above are accepted?
There was a problem hiding this comment.
I just wanted to test it out this way, had no idea that it'd work lol
IvanIvanoff
reviewed
Jun 2, 2022
Closed
IvanIvanoff
reviewed
Jun 13, 2022
IvanIvanoff
reviewed
Jun 15, 2022
Jenkinsfile
Outdated
| @@ -1,5 +1,5 @@ | |||
| podTemplate(label: 'sanpy-builder', containers: [ | |||
| containerTemplate(name: 'python', image: 'python:3-stretch', command: 'cat', ttyEnabled: true) | |||
| containerTemplate(name: 'python', image: 'python:3.9-buster', command: 'cat', ttyEnabled: true) | |||
There was a problem hiding this comment.
maybe 3.8 so we don't accidentally introduce a 3.9 requirement
IvanIvanoff
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.