-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-hardcoded versions #144
Conversation
@@ -22,7 +22,7 @@ | |||
'Cython' | |||
], | |||
install_requires=[ | |||
'pandas==1.3.0', | |||
'pandas>=1.3.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does >=
work? Does it mean that only the last digit in the version can change (i.e. from 1.3.0 to 1.3.99, but not to 1.4.0) or all versions above are accepted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to test it out this way, had no idea that it'd work lol
Jenkinsfile
Outdated
@@ -1,5 +1,5 @@ | |||
podTemplate(label: 'sanpy-builder', containers: [ | |||
containerTemplate(name: 'python', image: 'python:3-stretch', command: 'cat', ttyEnabled: true) | |||
containerTemplate(name: 'python', image: 'python:3.9-buster', command: 'cat', ttyEnabled: true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe 3.8 so we don't accidentally introduce a 3.9 requirement
No description provided.