Add integration testing #28
Conversation
|
Should these tests always run in the CI as they require internet and sanbase? |
setup.py
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| setuptools.setup( | |||
| name="sanpy", | |||
| version="0.0.20", | |||
| version="0.0.21", | |||
There was a problem hiding this comment.
What is the logic behind the version system, do we use in sanpy?
Usually, the third value is the bugs/fixes.
There was a problem hiding this comment.
@Partysun For now we're just bumping the version so we can upload to pypi. But this is a good suggestion - we may start utilizing what you suggested: major.minor.bugfixes. So this PR should bump the minor. Also adding a CHANGELOG file
setup.py
Outdated
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| setuptools.setup( | |||
| name="sanpy", | |||
| version="0.0.20", | |||
| version="0.1.20", | |||
There was a problem hiding this comment.
If you bump the second number you need to set the last to 0 -> 0.1.0
|
@IvanIvanoff There is some tradeoff with running tests that require external dependancy but I think having this kind of integration test will be more beneficial than making problems. We can try it on and see how it goes. |
|
Can we run these tests with a special command and not run them by default when building the PRs? This way we will be able to define a separate build job which runs these once a day? My concern is that if sanbase goes down all the builds will stop working and the master branch will be blocked... |
|
The command for running integration tests is: |
Check whether all queries to sanbase return result