-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration testing #28
Conversation
Should these tests always run in the CI as they require internet and sanbase? |
setup.py
Outdated
@@ -6,7 +6,7 @@ | |||
|
|||
setuptools.setup( | |||
name="sanpy", | |||
version="0.0.20", | |||
version="0.0.21", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the logic behind the version system, do we use in sanpy?
Usually, the third value is the bugs/fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Partysun For now we're just bumping the version so we can upload to pypi. But this is a good suggestion - we may start utilizing what you suggested: major.minor.bugfixes
. So this PR should bump the minor. Also adding a CHANGELOG file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup.py
Outdated
@@ -6,7 +6,7 @@ | |||
|
|||
setuptools.setup( | |||
name="sanpy", | |||
version="0.0.20", | |||
version="0.1.20", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you bump the second number you need to set the last to 0 -> 0.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups yes, indeed
@IvanIvanoff There is some tradeoff with running tests that require external dependancy but I think having this kind of integration test will be more beneficial than making problems. We can try it on and see how it goes. |
Can we run these tests with a special command and not run them by default when building the PRs? This way we will be able to define a separate build job which runs these once a day? My concern is that if sanbase goes down all the builds will stop working and the master branch will be blocked... |
The command for running integration tests is:
|
Check whether all queries to sanbase return result