Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ideas about the script #3

Closed
Dither opened this issue Feb 26, 2012 · 3 comments
Closed

Some ideas about the script #3

Dither opened this issue Feb 26, 2012 · 3 comments

Comments

@Dither
Copy link

Dither commented Feb 26, 2012

:contains pseudo-class is very incompatible with browsers (also deprecated in CSS3) so I've removed it from the script but some more xpathes can be safely converted. See my port for example.

@santiycr
Copy link
Owner

santiycr commented Mar 3, 2012

Hi @Dither, I agree about :contains and would love to see your improvements.
Would you mind forking the repo, updating and sending me a pull request? That would definitely make it easier to see the changes you've made and incorporate them while keeping your ownership in them.

@Dither
Copy link
Author

Dither commented Mar 3, 2012

I am not proficient in python as in javascript so if you can't apply ideas from my javascript port (see the link in the first message) then I can't do much. >_>

The main ideas that applicable here are:

  • splitting XPath for parts divided by |
  • tag/following-sibling in the main navigation block -> +
  • tag[1] - >:first-of-type
  • tag[last()] -> :last-of-type

PS: I don't mind if you not mention my contribution because I believe that "copyrighting" small chunks of code is out of place practice.

@santiycr
Copy link
Owner

santiycr commented Mar 3, 2012

oops, sorry. Didn't notice you actually made a full javascript port. Good job!
I'll check it out and see the important changes I can pull to the python version.

@Dither Dither closed this as completed Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants