Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for shared containers. #11

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Added support for shared containers. #11

merged 1 commit into from
Oct 5, 2017

Conversation

BlueMilkApps
Copy link
Contributor

Refactored the Directory enum a bit in order to support shared containers, as well as the createURL function to support it. Also added matching error code.

@BlueMilkApps BlueMilkApps mentioned this pull request Oct 4, 2017
@saoudrizwan saoudrizwan merged commit 07551f9 into saoudrizwan:master Oct 5, 2017
@saoudrizwan
Copy link
Owner

saoudrizwan commented Oct 5, 2017

Hey @RiverbayChris, sorry for the late reply (been busy releasing this.) Thank you so much for your interest in Disk and for your contributions! I merged this PR and updated the pod to include it. I also added a bit of information about the .sharedContainer directory in the Usage section on the README. Please double check it and feel free to send a PR of updated info.
Cheers!

@BlueMilkApps
Copy link
Contributor Author

Looks great, thanks. Nice looking app too! Congrats on the launch.

@BlueMilkApps BlueMilkApps deleted the shared-container-support branch October 5, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants