Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] fd-form-message content not announced #11595

Closed
m8524769 opened this issue Mar 20, 2024 · 3 comments · Fixed by #12292
Closed

[Accessibility] fd-form-message content not announced #11595

m8524769 opened this issue Mar 20, 2024 · 3 comments · Fixed by #12292
Assignees
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support ng15 Angular 15 support

Comments

@m8524769
Copy link

Is this a bug, enhancement, or feature request?

bug

Describe your proposal.

On accessing input fields with fd-form-message using keyboard/mouse, the message should be announced.

Can you handle that on the application side

no

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)

0.43.21

If this is a bug, please provide steps for reproducing it; the exact components you are using;

Access input field with fd-form-message.

Please provide relevant source code (if applicable).

Please provide stackblitz example(s).

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.

Did you check the documentation and the API?

yes

Did you search for similar issues?

yes

Is there anything else we should know?

@droshev
Copy link
Contributor

droshev commented Mar 21, 2024

@m8524769 did you set all aria attributes needed? If so, can you create a small stackblitz example demonstrating that you cannot set this on the application side?

@droshev droshev added the accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support label Mar 21, 2024
@m8524769
Copy link
Author

@m8524769 did you set all aria attributes needed? If so, can you create a small stackblitz example demonstrating that you cannot set this on the application side?

Hi @droshev, thanks for your reply, it could be reproduced in the latest documentation and I don't think we should set aria attributes on the application side.

@droshev droshev added the ng15 Angular 15 support label Jun 11, 2024
@mikerodonnell89
Copy link
Member

@m8524769 Because the <fd-form-input-message-group> component (like from the link you provided) is agnostic to whatever is placed inside of it via ng-content, we advise that you should handle aria attributes on the application side. If we were to set these attribrutes on the fd-form-message internally in the library to force an announcement, it would potentially override or interrupt whatever the screenreader had originally planned to say, possibly set by the application. So unfortunately it is best to handle this application side, like you see in the examples here: https://sap.github.io/fundamental-ngx/#/core/form-message

However, our documentation in the link you provided should be utilizing aria-describedby so I'll be updating that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility use this label for any issue or enhancement related to screenreader/keyboard/etc support ng15 Angular 15 support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants