Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail after a fresh install since the release of less-openui5@0.5.4 #405

Closed
2 of 6 tasks
codeworrior opened this issue Jul 5, 2018 · 3 comments
Closed
2 of 6 tasks
Assignees
Labels
bug Something isn't working module/ui5-builder Related to the UI5 Builder module

Comments

@codeworrior
Copy link
Member

Expected Behavior

Tests for ui5-builder should succeed.

Current Behavior

CSS related tests fail after a fresh npm install since the release of less-openui5@0.5.4

Steps to reproduce the issue

  1. rm -r node_modules
  2. npm install (or yarn or meta)
  3. npm run unit

Context

  • OS/Platform: doesn't matter...
  • Node.js Version: doesn't matter...
  • npm Version: doesn't matter...
  • Browser (if relevant): doesn't matter...
  • Other information: doesn't matter...

Affected components

Stack trace/log output

 - #sap-ui-theme-super\\.duper\\.looper { background-image: url('data:text/plain;utf-8,%7B%22deepSea%22:%22#123456%22%7D'); }␊
  + #sap-ui-theme-super\\.duper\\.looper { background-image: url('data:text/plain;utf-8,%7B%22deepSea%22:%22%23123456%22%7D'); }␊

Either the tests have to be adapted (and must be in sync with the installed less-openui5 version) or the version of less-openui5 must be hardwired to 0.5.3 until the whole topic has settled.

@matz3
Copy link
Member

matz3 commented Jul 5, 2018

My bad. I reverted the encoding PR but didn't think about our tests within the new tooling. I will fix them.

@matz3 matz3 self-assigned this Jul 5, 2018
matz3 referenced this issue in SAP/ui5-builder Jul 5, 2018
@codeworrior
Copy link
Member Author

As discussed in a separate conversation, the issue might have been caused by an unintentional npm update on my side. If you want to stay with the current version of the dependency and keep the (future proof) tests, I don't mind if you close this issue.

I anyhow approved your PR in case you want to follow that road.

@matz3
Copy link
Member

matz3 commented Jul 6, 2018

No, the current version 0.5.3 was broken, see SAP/less-openui5#26.

matz3 referenced this issue in SAP/ui5-builder Jul 6, 2018
@RandomByte RandomByte transferred this issue from SAP/ui5-builder Nov 20, 2020
@RandomByte RandomByte added bug Something isn't working module/ui5-builder Related to the UI5 Builder module labels Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module/ui5-builder Related to the UI5 Builder module
Projects
None yet
Development

No branches or pull requests

3 participants