Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose API, require basic auth #92

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Expose API, require basic auth #92

merged 2 commits into from
Jan 17, 2024

Conversation

SuperSandro2000
Copy link
Member

No description provided.

majewsky
majewsky approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion:

internal/api/api.go Outdated Show resolved Hide resolved
@SuperSandro2000 @majewsky
Use http.error instead of two calls
249c554 
Co-authored-by: Stefan Majewsky <stefan.majewsky@sap.com>
@SuperSandro2000 SuperSandro2000 merged commit 02c3ad5 into master Jan 17, 2024
6 checks passed
@SuperSandro2000 SuperSandro2000 deleted the basic-auth branch January 17, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperSandro2000 @majewsky