You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new github action to automatically insert SAP copyright and Apache license information into all of our files uses the wrong comment format for .mdx files (html styles <!-- --> comments).
This causes building/running storybook, the environment we use to develop juno-ui-components, to fail.
The proper comments are /* */ or /_ _/ comments. I have fixed these for now manually, but I would expect the new github action to automatically insert the info into any newly created .mdx file, so we need to make sure to use the correct comment syntax in the action.
To check whether storybook runs correctly, you can use npm --w juno-ui-components run storybook.
The text was updated successfully, but these errors were encountered:
The newly introduced github-action to automatically insert copyright and license information into each file in our project currently uses the wrong comment syntax for .mdx files, causing the storybook build to fail.
Created #590 to address fixing this permanently.
The newly introduced github-action to automatically insert copyright and license information into each file in our project currently uses the wrong comment syntax for .mdx files, causing the storybook build to fail.
Created #590 to address fixing this permanently.
The newly introduced github-action to automatically insert copyright and license information into each file in our project currently uses the wrong comment syntax for .mdx files, causing the storybook build to fail.
Created #590 to address fixing this permanently.
We removed the workflow that automatically added the license header. Instead, we implemented a checker to ensure the license header is present, requiring the developer to add it manually.
The new github action to automatically insert SAP copyright and Apache license information into all of our files uses the wrong comment format for
.mdx
files (html styles<!-- -->
comments).This causes building/running storybook, the environment we use to develop juno-ui-components, to fail.
The proper comments are
/* */
or/_ _/
comments. I have fixed these for now manually, but I would expect the new github action to automatically insert the info into any newly created.mdx
file, so we need to make sure to use the correct comment syntax in the action.To check whether storybook runs correctly, you can use
npm --w juno-ui-components run storybook
.The text was updated successfully, but these errors were encountered: