Fix missing map initialization in ParseData()

controllers/node_controller.go

@@ -161,6 +161,7 @@ func reconcileInternal(params reconcileParameters) error {
 	if err != nil {
 		return err
 	}
+	log.Info("ntoficationtimes map", "value", data.LastNotificationTimes)
 	profilesStr, ok := node.Labels[constants.ProfileLabelKey]
 	if !ok {
 		profilesStr = constants.DefaultProfileName

state/state.go

@@ -92,6 +92,9 @@ func ParseData(node *v1.Node) (Data, error) {
 			return Data{}, fmt.Errorf("failed to parse json value in data annotation: %w", err)
 		}
 	}
+	if data.LastNotificationTimes == nil {
+		data.LastNotificationTimes = make(map[string]time.Time)
+	}
 	return data, nil
 }
 
@@ -164,7 +167,7 @@ func Apply(state NodeState, node *v1.Node, data *Data, params plugin.Parameters)
 	return state.Label(), nil
 }
 
-// notifyDefault is a default NodeState.Transition implementation that checks
+// transitionDefault is a default NodeState.Transition implementation that checks
 // each specified transition in order and returns the next state. If len(trans)
 // is 0, the current state is returned.
 func transitionDefault(params plugin.Parameters, current NodeStateLabel, trans []Transition) (NodeStateLabel, error) {

state/state_test.go

@@ -30,6 +30,7 @@ import (
 	"github.com/go-logr/logr"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
+	"github.com/sapcc/maintenance-controller/constants"
 	"github.com/sapcc/maintenance-controller/plugin"
 	v1 "k8s.io/api/core/v1"
 	"k8s.io/client-go/tools/record"
@@ -246,3 +247,15 @@ var _ = Describe("Apply", func() {
 	})
 
 })
+
+var _ = Describe("ParseData", func() {
+
+	It("should initialize the notification times map", func() {
+		var node v1.Node
+		node.Annotations = map[string]string{constants.DataAnnotationKey: "{}"}
+		data, err := ParseData(&node)
+		Expect(err).To(Succeed())
+		Expect(data.LastNotificationTimes).ToNot(BeNil())
+	})
+
+})