Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mrm-task-eslint] prettier/@typescript-eslint is no more needed. #169

Closed
riywo opened this issue May 6, 2021 · 0 comments
Closed

[mrm-task-eslint] prettier/@typescript-eslint is no more needed. #169

riywo opened this issue May 6, 2021 · 0 comments

Comments

@riywo
Copy link

riywo commented May 6, 2021

When I ran mrm typescript prettier eslint, mrm added prettier/@typescript-eslint to .eslintrc.json. However, with the latest version of eslint-config-prettier, eslint won't work:

Error: Cannot read config file: /Users/riywo/riywo.com/app/node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Referenced from: /Users/riywo/riywo.com/app/.eslintrc.json

I think we can remove prettier/@typescript-eslint from here:

const extensions = eslintrc.get('extends', []);
eslintrc.merge({
extends: [
...(Array.isArray(extensions) ? extensions : [extensions]),
'prettier',
'prettier/@typescript-eslint',
],
});

I confirmed eslint works once I removed prettier/@typescript-eslint by hand.

@riywo riywo changed the title prettier/@typescript-eslint is no more needed. prettier/@typescript-eslint is no more needed. May 6, 2021
@riywo riywo changed the title prettier/@typescript-eslint is no more needed. [mrm-task-eslint] prettier/@typescript-eslint is no more needed. May 6, 2021
Repository owner locked and limited conversation to collaborators Sep 13, 2023
@sapegin sapegin converted this issue into discussion #311 Sep 13, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

2 participants