Removing unnessssary DDIC dependencies

[larshp]

Suggest replacing usages of the following types with builtin types like C and abap_bool

BOOLEAN 9
CHAR_02 2
CHAR01 6
CHAR07 44
CHAR08 1
CHAR1 31
CHAR10 23
CHAR2 8
CHAR20 925
CHAR255 181
CHAR3 305
CHAR5 18
CHAR50 180
CHAR7 4
CHAR8 537
DATS 1 (only used in zcl_excel_ole)
DATUM 14 (only used in calendar demo)
FLAG 3987
INT1 646 (DTEL is Steampunk released object, DOMA should not be used)
INT2 384 (DTEL is Steampunk released object, DOMA should not be used)
INT4 1318 (DTEL is Steampunk released object, DOMA should not be used)
INTTYPE 28 #898
NUM1 3
NUM8 1
NUMC1 44
NUMC3 3
OS_BOOLEAN 41
XFELD 898
DOMA TEXT31
DOMA UUID, #924
DOMA FIELDNAME
GUID_16, #924

[AndreaBorgia-Abo]

@larshp couple of questions:

1. what do the numbers in your list represent? I can't find more than 16 uses of CHAR20 under src/, for example.
2. I assume we ought to remove them from every users, right? In this case, may I edit the original report to add strikethroughs for items already gone? It makes it easier to spot what's left on such a boring and long running task.

[larshp]

1: its the number of times its referenced, daily updated numbers at https://abaplint.app/stats/sapmentors/abap2xlsx/void_types, but it might be buggy

2: yea, sure, feel free

[AndreaBorgia-Abo]

I have marked as removed a couple of items above because either they're found in a "non cloud" source or in a demo report. Hope this is fine.

[AndreaBorgia-Abo]

Regarding INTTYPE, I'm not sure that it makes sense to remove it: other than in ZEXCEL_S_CONVERTER_FCAT, it is also used in LVC_S_FCAT which is in turn used by ZCL_EXCEL_CONVERTER (see ZDEMO_EXCEL32). We'd have to remove LVC_S_FCAT as well or clone it or... maybe move these to the "non cloud" package?

If the rationale is to be BTP-ready, how do I know that INTTYPE is not kosher?

OTOH LVC_S_FCAT seems to be offlimits:

(screenshot taken from BTP trial instance, created today)

EDIT: here is the PR, just in case

[larshp]

todo:

• DOMA TEXT31
• DOMA UUID
• DOMA FIELDNAME
• DOMA GUID_16
• DTEL SYTABIX
• DTEL SYLANGU
  and more

[AndreaBorgia-Abo]

todo:

I've added them to the list in the first comment, easier to track this way

[gregorwolf]

Another one will be fixed with #936

[gregorwolf]

This is the activation error list I currently get with my Steampunk system:

TABL ZEXCEL_S_CONVERTER_COL was not activated
Check table ZEXCEL_S_CONVERTER_COL (CB9980000000/12/28/21/15:0
Use of Data Element FIELDNAME is not permitted.
Use of Data Element LVC_NOKEYC is not permitted.
Check on table ZEXCEL_S_CONVERTER_COL resulted in errors
TABL ZEXCEL_S_CONVERTER_FCAT was not activated
Check table ZEXCEL_S_CONVERTER_FCAT (CB9980000000/12/28/21/15:
Field name POSITION is reserved (Do not use structure as include in DB table)
Use of Data Element CONVEXIT is not permitted.
Use of Data Element FIELDNAME is not permitted.
Data Element FLAG is deprecated. Use Data Element ABAP_BOOLEAN instead.
Use of Data Element LVC_COLID is not permitted.
Use of Data Element SCRTEXT_L is not permitted.
Use of Data Element SCRTEXT_M is not permitted.
Use of Data Element SCRTEXT_S is not permitted.
Use of Data Element TABFDPOS is not permitted.
Use of Table DD02L is not permitted.
Use of Table DD03L is not permitted.
Check on table ZEXCEL_S_CONVERTER_FCAT resulted in errors
TABL ZEXCEL_S_CONVERTER_FIL was not activated
Check table ZEXCEL_S_CONVERTER_FIL (CB9980000000/12/28/21/15:0
Use of Data Element FIELDNAME is not permitted.
Check on table ZEXCEL_S_CONVERTER_FIL resulted in errors
TABL ZEXCEL_S_FIELDCATALOG was not activated
Check table ZEXCEL_S_FIELDCATALOG (CB9980000000/12/28/21/15:07
Field name POSITION is reserved (Do not use structure as include in DB table)
Use of Data Element DYNPROFLD is not permitted.
Use of Data Element FIELDNAME is not permitted.
Data Element FLAG is deprecated. Use Data Element ABAP_BOOLEAN instead.
Use of Data Element SCRTEXT_L is not permitted.
Use of Data Element SCRTEXT_M is not permitted.
Use of Data Element SCRTEXT_S is not permitted.
Use of Data Element TABFDPOS is not permitted.
Check on table ZEXCEL_S_FIELDCATALOG resulted in errors
TTYP ZEXCEL_T_CONVERTER_COL was not activated
Check table type ZEXCEL_T_CONVERTER_COL (CB9980000000/12/28/21/15:0
Row type ZEXCEL_S_CONVERTER_COL is not active or does not exist
Table type ZEXCEL_T_CONVERTER_COL is inconsistent
TTYP ZEXCEL_T_CONVERTER_FCAT was not activated
Check table type ZEXCEL_T_CONVERTER_FCAT (CB9980000000/12/28/21/15:
Row type ZEXCEL_S_CONVERTER_FCAT is not active or does not exist
Table type ZEXCEL_T_CONVERTER_FCAT is inconsistent
TTYP ZEXCEL_T_CONVERTER_FIL was not activated
Check table type ZEXCEL_T_CONVERTER_FIL (CB9980000000/12/28/21/15:0
Row type ZEXCEL_S_CONVERTER_FIL is not active or does not exist
Table type ZEXCEL_T_CONVERTER_FIL is inconsistent
TTYP ZEXCEL_T_FIELDCATALOG was not activated
Check table type ZEXCEL_T_FIELDCATALOG (CB9980000000/12/28/21/15:07
Row type ZEXCEL_S_FIELDCATALOG is not active or does not exist
Table type ZEXCEL_T_FIELDCATALOG is inconsistent

[larshp]

I guess above is only the DDIC activation. Eg. use of the "DESCRIBE" statement is not allowed in steampunk but in the abap2xlsx code

I think most of the findings in https://github.com/abap2xlsx/abap2xlsx/pull/925/checks?check_run_id=4655710541 are correct

[sandraros]

Current situation (SAP S/4HANA Public Cloud), filtering the Dictionary Log on "error":

TABL ZEXCEL_S_CONVERTER_COL was not activated                         error  D0(408)
The use of Data Element LVC_NOKEYC is not permitted.                  error  LA(020)
TABL ZEXCEL_S_CONVERTER_FCAT was not activated                        error  D0(408)
The use of Data Element CONVEXIT is not permitted.                    error  LA(020)
The use of Data Element LVC_COLID is not permitted.                   error  LA(020)
The use of Data Element SCRTEXT_L is not permitted.                   error  LA(020)
The use of Data Element SCRTEXT_M is not permitted.                   error  LA(020)
The use of Data Element SCRTEXT_S is not permitted.                   error  LA(020)
The use of Data Element TABFDPOS is not permitted.                    error  LA(020)
The use of Table DD02L is not permitted.                              error  LA(020)
TABL ZEXCEL_S_FIELDCATALOG was not activated                          error  D0(408)
The use of Data Element DYNPROFLD is not permitted.                   error  LA(020)
The use of Data Element SCRTEXT_L is not permitted.                   error  LA(020)
The use of Data Element SCRTEXT_M is not permitted.                   error  LA(020)
The use of Data Element SCRTEXT_S is not permitted.                   error  LA(020)
The use of Data Element TABFDPOS is not permitted.                    error  LA(020)
TTYP ZEXCEL_T_CONVERTER_COL was not activated                         error  D0(408)
Row type ZEXCEL_S_CONVERTER_COL is not active or does not exist       error  DO(845)
TTYP ZEXCEL_T_CONVERTER_FCAT was not activated                        error  D0(408)
Row type ZEXCEL_S_CONVERTER_FCAT is not active or does not exist      error  DO(845)
TTYP ZEXCEL_T_FIELDCATALOG was not activated                          error  D0(408)
Row type ZEXCEL_S_FIELDCATALOG is not active or does not exist        error  DO(845)

[larshp]

@sandraros looks like its just the DDIC stuff(which is also the topic of this issue), but theres also a lot of code changes to be made, https://github.com/abap2xlsx/abap2xlsx/runs/20393685451

one code change is #1125