-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for PyPREP/MatPREP highpass differences #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect :-) Thanks a lot!
Er, looks like MNE needs an additional module to download test datasets now? Should I add that to this PR as well? |
ah right 🤔 yes please - we can just add it here: https://github.com/sappelhoff/pyprep/blob/master/requirements-dev.txt |
although but no harm in adding it now to merge this PR, and then removing it again some time in the future when we don't need to declare it explicitly anymore. |
Whoops, looks like matplotlib's changed its API on us since last update too. I'll try to tackle that as well. |
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 7 7
Lines 733 733
=======================================
Hits 726 726
Misses 7 7 Continue to review full report at Codecov.
|
Thank you :) |
PR Description
Closes #107. This PR updates the docs to contain a better explanation of the differences between PyPREP's and MatPREP's trend removal filters (and why the MNE method is technically preferable).
Wasn't sure if this warranted an addition in the
whats_new.rst
, but if it does I can definitely add a line!Merge Checklist
closes #<issue-number>
to automatically close an issue