-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(structures): add global preconditions #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
previously approved these changes
Feb 15, 2021
RealShadowNova
previously approved these changes
Feb 15, 2021
favna
requested changes
Feb 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were several suggestions from @RealShadowNova. Personally I kinda like essentials
kyranet
dismissed stale reviews from RealShadowNova and vladfrangu
via
February 15, 2021 19:55
aec95a2
favna
changed the title
feat: added global preconditions
feat(structures): add esssentials. global preconditions
Feb 15, 2021
RealShadowNova
previously approved these changes
Feb 15, 2021
vladfrangu
previously approved these changes
Feb 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still finding it overkill that its a whole structure but LGTM
favna
requested changes
Feb 15, 2021
kyranet
dismissed stale reviews from vladfrangu and RealShadowNova
via
February 15, 2021 21:03
5776e8e
Co-authored-by: Jeroen Claassens <support@favware.tech>
Co-authored-by: Jeroen Claassens <support@favware.tech>
Co-authored-by: Jeroen Claassens <support@favware.tech>
favna
previously approved these changes
Feb 15, 2021
kyranet
force-pushed
the
feat/added-global-preconditions
branch
from
February 15, 2021 21:38
5e58bd1
to
9d8f94a
Compare
kyranet
changed the title
feat(structures): add esssentials. global preconditions
feat(structures): add global preconditions
Feb 15, 2021
favna
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.