Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(structures): add global preconditions #176

Merged
merged 9 commits into from
Feb 15, 2021

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Feb 15, 2021

No description provided.

@kyranet kyranet requested a review from favna as a code owner February 15, 2021 18:52
@kyranet kyranet requested a review from a team February 15, 2021 18:52
vladfrangu
vladfrangu previously approved these changes Feb 15, 2021
RealShadowNova
RealShadowNova previously approved these changes Feb 15, 2021
Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were several suggestions from @RealShadowNova. Personally I kinda like essentials

src/lib/structures/Precondition.ts Show resolved Hide resolved
src/lib/structures/PreconditionStore.ts Show resolved Hide resolved
@favna favna changed the title feat: added global preconditions feat(structures): add esssentials. global preconditions Feb 15, 2021
RealShadowNova
RealShadowNova previously approved these changes Feb 15, 2021
vladfrangu
vladfrangu previously approved these changes Feb 15, 2021
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still finding it overkill that its a whole structure but LGTM

src/lib/structures/Essential.ts Outdated Show resolved Hide resolved
kyranet and others added 3 commits February 15, 2021 22:03
Co-authored-by: Jeroen Claassens <support@favware.tech>
Co-authored-by: Jeroen Claassens <support@favware.tech>
Co-authored-by: Jeroen Claassens <support@favware.tech>
favna
favna previously approved these changes Feb 15, 2021
@kyranet kyranet force-pushed the feat/added-global-preconditions branch from 5e58bd1 to 9d8f94a Compare February 15, 2021 21:38
@kyranet kyranet changed the title feat(structures): add esssentials. global preconditions feat(structures): add global preconditions Feb 15, 2021
@favna favna enabled auto-merge (squash) February 15, 2021 21:55
@favna favna merged commit e8ef41f into main Feb 15, 2021
@favna favna deleted the feat/added-global-preconditions branch February 15, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants