feat: export sapphire package version #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
favna
requested changes
Mar 2, 2021
There was a problem hiding this comment.
This doesn't work because changing the rootDir causes the output to have /dist/src instead of just all the files from src
There are ways to inject the data at build time through Rollup, so if you want this feature then please look into such an option and validate the output bundle with the prepublishOnly script as opposed to build. Note that you'll have to run Rollup twice, once to replace the value, once to bundle the types as happens now.
favna
reviewed
Mar 2, 2021
| @@ -43,3 +43,5 @@ export * from './lib/utils/preconditions/containers/PermissionsPrecondition'; | |||
| export * from './lib/utils/preconditions/IPreconditionContainer'; | |||
| export * from './lib/utils/preconditions/PreconditionContainerArray'; | |||
| export * from './lib/utils/preconditions/PreconditionContainerSingle'; | |||
|
|
|||
| export const version = '[VI]{version}[/VI]'; | |||
There was a problem hiding this comment.
After prepublishOnly script this is replaced with the following in dist/index.js:
exports.version = '1.0.0-alpha.11';
favna
previously approved these changes
Mar 2, 2021
favna
approved these changes
Mar 2, 2021
vladfrangu
approved these changes
Mar 2, 2021
kyranet
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.