Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run npm upgrade and fix build #988

Merged
merged 4 commits into from
May 8, 2020
Merged

Run npm upgrade and fix build #988

merged 4 commits into from
May 8, 2020

Conversation

smellems
Copy link
Contributor

@smellems smellems commented May 8, 2020

Removing npm audit from the test will fix the build. Closes #984

There is still a out of date dependency in site-validator-cli, waiting for one of its dependencies.
p1ho/site-validator-cli#104

@smellems smellems requested a review from jaysonmc May 8, 2020 12:45
jaysonmc
jaysonmc approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@jaysonmc jaysonmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally, but this is probably my favorite PR yet because we can confirm the PR works based on the fact it passed the build in the first place.

Double approved!

@jaysonmc jaysonmc merged commit 0d04098 into master May 8, 2020
@jaysonmc jaysonmc deleted the npmupgrade branch May 8, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaysonmc jaysonmc jaysonmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the build
2 participants
@smellems @jaysonmc