Fix CreateRaw() flags and timestamps #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the standard Go library's version of
CreateRaw
was added, rather than solely focus on custom compression in "raw" mode, it also removed the convenience of setting up common zip flags and timestamp logic.This change duplicates some functions from
archive/zip
to add the flags and timestamp logic toCreateRaw()
.This fixes an issue raised by a user of GitLab-Runner https://gitlab.com/gitlab-org/gitlab-runner/-/issues/28928 where timestamps were missing whenever
CreateRaw
was used.