Rate-limit active go routines #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filepool's Get()/Put() was designed to rate limit up to a certain concurrency, and whilst the unit of work is rate limited, we launch as many go routines as there are files to be archived first. By moving the Get() call outside of a go routine, we also limit the amount of go routines created at once. This likely has memory savings, but also allows the "-race" detector to work when archiving many thousands of files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
filepool'sGet()/Put()was designed to rate limit up to a certain concurrency, and whilst the unit of work is rate limited, we launch as many go routines as there are files to be archived first. By moving theGet()call outside of a go routine, we also limit the amount of go routines created at once.This likely has memory savings, but also allows the
-racedetector to work when archiving many thousands of files.