Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with ESLint 7.8.0 #331

Closed
soda0289 opened this issue Sep 1, 2020 · 4 comments
Closed

Breaks with ESLint 7.8.0 #331

soda0289 opened this issue Sep 1, 2020 · 4 comments

Comments

@soda0289
Copy link
Contributor

soda0289 commented Sep 1, 2020

I get the following error with eslint 7.8.0:

Error: eslint naming functions not found

Looks like this tool tries to access the normalization functions from eslint in the file "eslint/lib/shared/naming".
https://github.com/sarbbottam/eslint-find-rules/blob/master/src/lib/normalize-plugin-name.js#L13

Looks like that file was removed in this change:
https://github.com/eslint/eslint/pull/13613/files#diff-bdb20110f0ab3020c5ffa945a4b79bce

@soda0289
Copy link
Contributor Author

soda0289 commented Sep 1, 2020

Those normalization functions have been moved to eslint/eslintrc package.
https://github.com/eslint/eslintrc/blob/main/lib/shared/naming.js

I can push fix to include this package as dependency and remove the require('eslint/....')

@ljharb
Copy link
Collaborator

ljharb commented Sep 1, 2020

A PR would be great; unfortunately this broke in a minor version.

soda0289 added a commit to soda0289/eslint-find-rules that referenced this issue Sep 1, 2020
@soda0289
Copy link
Contributor Author

soda0289 commented Sep 1, 2020

@ljharb Created PR #332

@soda0289
Copy link
Contributor Author

Confirmed eslint 7.8.0 and 7.9.0 work with eslint-find-fules 3.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants