-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): travis-after-all #3
Conversation
Current coverage is
|
@ta2edchimp could you take a look? |
@@ -6,7 +6,7 @@ cache: | |||
notifications: | |||
email: false | |||
node_js: | |||
- '4' | |||
- stable | |||
- '0.10' | |||
before_install: | |||
- npm i -g npm@^3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd definitely test on npm@^2.0.0
too. There seems to be a whole lot of devs still using not only node@0.1x
, but also npm@^2.0.0
. On ghooks
I introduced a script that decides which version of npm to install based on the current node version. (This is mainly because of something I can only describe as a bug, in npm@2.15.x
and I think it would be good to cover such cases as early as possible.)
Boy, am I nitpicking (I just learned that word) 😜 Other than my notes 👍 |
Maybe, when merging, from now on we could mostly use the "squash and merge" feature? I think we both still have lots of ideas for this module, and that way we'd keep the commit history relatively clean and short. |
I guess this one will trigger a new release, the first release, because #2 did not yet. |
1483b72
to
91434da
Compare
@ta2edchimp, I have addressed the review comments. Please have a look when you get time. My 💵 0.02 for the other suggestions
👍
Absolutely, will hold on to this, till the suggested change are done. If you get time feel free to raise PR for the same, Otherwise I would do it tomorrow morning, quite busy schedule today. BTW, you have full access to the repo. |
Should we disable release for the repo now and enable it only after
|
91434da
to
b019b59
Compare
using travis-after-all npm module
b019b59
to
8729057
Compare
I guess so. Would be a nice clean new release then 👍 Re I'm afraid I won't have much time until later at the weekend as it's birthday week in the family. But depending on how much time you got for this, mind beginning posting issues for the features we came along in the last days? We then might pick us some to realize or discuss those that need it. Btw. do you know |
Nope, looks great! This PR disables the semantic release.
Do you think its good to be merged? If |
LGTM 👍 |
closed in favor of #4 |
using travis-after-all npm module