feat(no-option): display error if no options are provided #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ta2edchimp could you take a look? |
| @@ -40,6 +40,12 @@ describe('bin', function() { | |||
| delete require.cache[require.resolve('yargs')] | |||
| }) | |||
|
|
|||
| it('no option', function() { | |||
There was a problem hiding this comment.
Any idea why this does not get mentioned in the PR's corresponding travis build logs?
There was a problem hiding this comment.
Current coverage is 100%@@ master #73 diff @@
===================================
Files 9 9
Lines 194 199 +5
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 194 199 +5
Misses 0 0
Partials 0 0
|
sarbbottam
force-pushed
the
no-options
branch
2 times, most recently
from
cd8a349
to
9e3766d
Compare
|
Is it good to merge? |
|
Ha, yeah, I forgot to add: "LGTM"! 😜 Pull the trigger! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.