Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opcode 17 error #61

Closed
wants to merge 1 commit into from
Closed

opcode 17 error #61

wants to merge 1 commit into from

Conversation

Yzgll
Copy link

@Yzgll Yzgll commented Apr 29, 2024

I deleted the kernels.hsaco file and it didn't work after it was recompiled, so I added some instructions to fix the problem

@syifan
Copy link
Contributor

syifan commented Apr 29, 2024

@Yzgll Just want to make sure, this version runs your newly compiled AES without error right?

@syifan
Copy link
Contributor

syifan commented Apr 29, 2024

It seems that the unit tests are currently failing after being added. Can you help me fix them, @Yzgll? It can be problems with the test, if your AES code passes.

@Yzgll
Copy link
Author

Yzgll commented Apr 30, 2024

It seems that the unit tests are currently failing after being added. Can you help me fix them, @Yzgll? It can be problems with the test, if your AES code passes.

It seems that the unit tests are currently failing after being added. Can you help me fix them, @Yzgll? It can be problems with the test, if your AES code passes.

Yeah, you're probably right, I don't do tests, so my test code is modeled after yours and it might be a little problematic. But I think the addition of opcode 17,42,0xA4 is correct, it helped me successfully run AES after recompiling and I was able to run it successfully without writing any tests on my own mgpusim.

@Yzgll Yzgll closed this by deleting the head repository Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants