Test utils #106
Merged
Test utils #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
November 27, 2022 17:42
…ate accuse tests to use new utilities, begin new embalmer specs
| revert LibErrors.NewResurrectionTimeInPast(resurrectionTime); | ||
| } | ||
|
|
||
| // Confirm that new resurrection time doesn't exceed sarcophagus's maximumRewrapInterval | ||
| if (resurrectionTime > block.timestamp + sarcophagus.maximumRewrapInterval) { | ||
| if (block.timestamp + sarcophagus.maximumRewrapInterval < resurrectionTime) { |
There was a problem hiding this comment.
Is there a reason you seem to be making sure block.timestamp appears earlier in these expressions? Some efficiency/edgecase shenanigans maybe? Or just a style choice?
There was a problem hiding this comment.
it is just a style thing haha I was running through all the code trying to evaluate it for readability and I personally think it's easier to follow if block timestamp is consistently the first thing in the checks
| @@ -39,6 +39,7 @@ struct AppStorage { | |||
| mapping(bytes32 => address) doubleHashedShardArchaeologists; | |||
|
|
|||
| // sarcophagus ids | |||
| // todo: is this used? | |||
There was a problem hiding this comment.
I highly doubt it. Seth and Kyle may have more context on if there was some future plans for having this
DarksightKellar
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.