DRAFT: Update publishkeyshares to publishprivatekey #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh-23378
reviewed
Dec 9, 2022
| @@ -36,4 +36,10 @@ library LibTypes { | |||
| uint256 freeBond; | |||
| uint256 cursedBond; | |||
| } | |||
|
|
|||
| struct Signature { | |||
There was a problem hiding this comment.
Think we're going to use this struct outside of thirdpartyfacet? If no, let's move it in there
gh-23378
reviewed
Dec 12, 2022
| // Recover the archaeologist's address from the signature. Note that the recoverAddress | ||
| // function will always return a valid address, even if the message does not match the | ||
| // signature. | ||
| address accusedArchaeologistAddress = LibUtils.recoverAddress( |
There was a problem hiding this comment.
This is going to recover the address corresponding to the public key the archaeologist has generated for the sarcophagus, but it's not going to be the same as the archaeologist's address.
We'll need to recover the full public key from the signature, then look up the archaeologist address given that public key in the new convenience mapping we're creating (publicKey=>archaeologistAddress)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this. I would just like to get some eyes on it.
publishKeySharefunction to accept a private key and renamed it topublishPrivateKey.publishPrivateKey.