Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion : Give an id/class to dialogue as an option. #26

Closed
mikecastrodemaria opened this issue Dec 26, 2015 · 5 comments
Closed
Assignees

Comments

@mikecastrodemaria
Copy link

Feature suggestion : add to options the ability to set an id and or class to the dialogue.

Ex param : var params = {modalId = 'my-modal-id', modalclass = 'my-modal-class' }
Ex modal :

....

It will help a lot to modify modal contextually.
Thanks

@oliverschloebe
Copy link

+1

@saribe
Copy link
Owner

saribe commented Jan 18, 2016

You can access the element, do you really need the id?

var promiseAndMore = eModal.alert('Hello Jack', 'From Madam');

promiseAndMore.element
     .find('modal-body')
     .addClass('my-very-cool-animation');

In the returned object from eModal execution, you get the jQuery DOM element reference.
You can do what ever you what with it.

But by the id or class could be helpful for you?

@saribe
Copy link
Owner

saribe commented Jan 25, 2016

Any update on this?

Can you give me an example why should we add this feature?

@saribe saribe self-assigned this Jan 25, 2016
@maxi032
Copy link

maxi032 commented Apr 21, 2016

because sometimes we need to check if the modal is shown or hidden and do stuff based on that

@saribe
Copy link
Owner

saribe commented Nov 2, 2016

Now it is possible to set id on eModal

eModal.setId('your-id');

@saribe saribe closed this as completed Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants