Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pickling issue #33

Merged
merged 6 commits into from
May 17, 2024
Merged

Fix pickling issue #33

merged 6 commits into from
May 17, 2024

Conversation

yalef
Copy link
Contributor

@yalef yalef commented May 16, 2024

Resolves: #31 #30

@yalef yalef marked this pull request as ready for review May 16, 2024 10:25
TheSuperiorStanislav
TheSuperiorStanislav reviewed May 17, 2024
View reviewed changes
Copy link
Member

@TheSuperiorStanislav TheSuperiorStanislav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to verify that it works?

@yalef
Copy link
Contributor Author

yalef commented May 17, 2024

Could you add a test to verify that it works?

I've added test for issue with pickle error (occurs when ValidationError related to field is raised during import)

But I won't add test for AttributeError case, because in this case error occur just because Job.result field had "" default value

NikAzanov
NikAzanov approved these changes May 17, 2024
View reviewed changes
import_export_extensions/results.py Outdated Show resolved Hide resolved
@yalef yalef merged commit 86fa77a into main May 17, 2024
11 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSuperiorStanislav TheSuperiorStanislav TheSuperiorStanislav approved these changes

@NikAzanov NikAzanov NikAzanov approved these changes

@OttoAndrey OttoAndrey Awaiting requested review from OttoAndrey OttoAndrey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError in list/detail api for jobs
3 participants
@yalef @TheSuperiorStanislav @NikAzanov