Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/updates to multiinstance #347

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

essweine
Copy link
Contributor

@essweine essweine commented Aug 2, 2023

This PR adds a task_info method that can be used to provide runtime information about tasks, based on the task spec and the task itself. The immediate requirement is to provide information about multiinstance tasks; however, this is a generic method that can be extended by any spec type to provide additional information to a process engine that is defined by that type based on the current state of the task.

Additionally, it

  • adds the ability to choose whether pre and post scripts on MI task specs in the spiff package should be attached to the MI task or the instance
  • raises an error if the specified input or output item of an MI task is already present in the task data

@essweine essweine marked this pull request as draft August 3, 2023 12:51
@essweine essweine force-pushed the improvement/updates-to-multiinstance branch from 9adbce4 to 167a037 Compare August 3, 2023 13:31
@danfunk
Copy link
Collaborator

danfunk commented Aug 3, 2023

So we have additional work it the backend and frontend to pick up this information and surface it in the UI? And additional work in the BPMN-IO to set the flag on when to execute the pre and post scripts?

@essweine
Copy link
Contributor Author

essweine commented Aug 3, 2023

I've already done the bpmn.js work to select where the scripts go, I just haven't opened a PR for it because this should be merged first (to avoid having something in the modeler that doesn't do anything).

The reason for adding the task_info method is to make it easier handle the UI in the frontend and is the stuff I've been working on this week. Spiff mostly already maintained this stuff in its internal data, this just exposes it in an easier way than doing db queries on the internal data of the tasks.

@essweine essweine marked this pull request as ready for review August 10, 2023 14:05
@essweine essweine merged commit 085bd0d into main Aug 10, 2023
4 checks passed
@essweine essweine deleted the improvement/updates-to-multiinstance branch August 10, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants